Skip to content

ARROW-15110: [C++][Gandiva] Revert change on Gandiva's cache policy#11957

Closed
augustoasilva wants to merge 10 commits intoapache:masterfrom
s1mbi0se:feature/revert-new-cache-eviction-policy-in-Gandiva
Closed

ARROW-15110: [C++][Gandiva] Revert change on Gandiva's cache policy#11957
augustoasilva wants to merge 10 commits intoapache:masterfrom
s1mbi0se:feature/revert-new-cache-eviction-policy-in-Gandiva

Conversation

@augustoasilva
Copy link
Copy Markdown
Contributor

@augustoasilva augustoasilva commented Dec 14, 2021 •
edited
Loading

Revert change on "ARROW-12986: [C++][Gandiva] Implement new cache eviction policy algorithm in Gandiva"

This reverts commit a628ee0

The commit that is being revered is causing random memory corruptions, based whe compiling the Gandiva to jars file for JNI:

#A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fdb8d427af8, pid=20974, tid=0x00007fdb8b669700
#
# JRE version: OpenJDK Runtime Environment (8.0_141-b16) (build 1.8.0_141-b16)
# Java VM: OpenJDK 64-Bit Server VM (25.141-b16 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libgandiva_jni.soa26ad92b-cf80-4777-98fc-5ea749c149ac+0x4afaf8]  gandiva::Projector::Make(std::shared_ptr<arrow::Schema>, std::vector<std::shared_ptr<gandiva::Expression>, std::allocator<std::shared_ptr<gandiva::Expression> > > const&, gandiva::SelectionVector::Mode, std::shared_ptr<gandiva::Configuration>, std::shared_ptr<gandiva::Projector>*)+0x858
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again

So this is a temporary revert 'till the actual memory corruption is found and fixed.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2021

https://issues.apache.org/jira/browse/ARROW-15110

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 14, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@augustoasilva augustoasilva force-pushed the feature/revert-new-cache-eviction-policy-in-Gandiva branch 4 times, most recently from 2cca22e to 3e8df3f Compare December 15, 2021 22:31
@augustoasilva augustoasilva marked this pull request as ready for review December 15, 2021 23:18
@augustoasilva augustoasilva force-pushed the feature/revert-new-cache-eviction-policy-in-Gandiva branch 4 times, most recently from b755035 to e996323 Compare December 17, 2021 23:03
@augustoasilva augustoasilva force-pushed the feature/revert-new-cache-eviction-policy-in-Gandiva branch from e996323 to dd09c56 Compare December 18, 2021 00:05
projjal
projjal reviewed Dec 20, 2021
View reviewed changes
projjal
projjal reviewed Dec 20, 2021
View reviewed changes
projjal
projjal reviewed Dec 20, 2021
View reviewed changes
@augustoasilva augustoasilva force-pushed the feature/revert-new-cache-eviction-policy-in-Gandiva branch from 8d11190 to 67f08c6 Compare December 20, 2021 11:10
@pravindra pravindra closed this in 02e9464 Dec 21, 2021
@ursabot
Copy link
Copy Markdown

ursabot commented Dec 21, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 9ac9405 and contender = 02e9464. 02e9464 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.62% ⬆️0.18%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@anthonylouisbsb anthonylouisbsb deleted the feature/revert-new-cache-eviction-policy-in-Gandiva branch January 27, 2022 22:43
@niyue niyue mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@projjal projjal projjal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++ Component: Gandiva

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@augustoasilva @ursabot @projjal