Skip to content

ARROW-15096: [R] Sanitizer failures with duration type #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paleolimbot wants to merge 3 commits into from
Closed

ARROW-15096: [R] Sanitizer failures with duration type #11947

paleolimbot wants to merge 3 commits into from

Conversation

@paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Dec 14, 2021

This PR is an attempt to fix the sanitizer failure caused by ARROW-14941 (#11850). @jonkeane could you remind me how to submit a job to the sanitizer checker?

@jonkeane
Copy link
Member

jonkeane commented Dec 14, 2021

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer test-ubuntu-18.04-r-sanitizer

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

https://issues.apache.org/jira/browse/ARROW-15096

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Revision: 9e38813

Submitted crossbow builds: ursacomputing/crossbow @ actions-1296

Task Status
test-ubuntu-18.04-r-sanitizer Azure

@jonkeane
Copy link
Member

jonkeane commented Dec 14, 2021

@github-actions crossbow submit test-fedora-r-clang-sanitizer

Oops, I duplicated the first instead of adding this one second 🙃

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Revision: 9e38813

Submitted crossbow builds: ursacomputing/crossbow @ actions-1297

Task Status
test-fedora-r-clang-sanitizer Azure

@pitrou
Copy link
Member

pitrou commented Dec 14, 2021

Looking at the logs, it seems there's another issue as well:


2021-12-14T15:47:09.4969247Z array_to_vector.cpp:929:13: runtime error: downcast of address 0x607000047fb0 which does not point to an object of type 'TimeType'
2021-12-14T15:47:09.4969957Z 0x607000047fb0: note: object is of type 'arrow::DurationType'
2021-12-14T15:47:09.4970338Z  01 00 00 00  48 19 50 0c 7e 7f 00 00  80 70 1c 00 30 60 00 00  00 00 00 00 00 00 00 00  21 00 00 00
2021-12-14T15:47:09.4970656Z               ^~~~~~~~~~~~~~~~~~~~~~~
2021-12-14T15:47:09.4971078Z               vptr for 'arrow::DurationType'
2021-12-14T15:47:09.4971961Z     #0 0x7f7dfb6e8be3 in arrow::r::Converter_Duration<long, arrow::TimeType>::TimeUnit_multiplier(std::shared_ptr<arrow::Array> const&) const (/usr/local/RDsan/lib/R/site-library/arrow/libs/arrow.so+0x1b974be3)
2021-12-14T15:47:09.4973033Z     #1 0x7f7dfb6d1377 in arrow::r::Converter_Duration<long, arrow::TimeType>::Ingest_some_nulls(SEXPREC*, std::shared_ptr<arrow::Array> const&, long, long, unsigned long) const (/usr/local/RDsan/lib/R/site-library/arrow/libs/arrow.so+0x1b95d377)
2021-12-14T15:47:09.4973956Z     #2 0x7f7dfb6259bc in arrow::r::Converter::ScheduleConvertTasks(arrow::r::RTasks&, std::shared_ptr<arrow::r::Converter>)::{lambda()#1}::operator()() const /arrow/r/src/array_to_vector.cpp:88

@pitrou
Copy link
Member

pitrou commented Dec 14, 2021

By the way, you can probably reproduce this locally using archery docker run ubuntu-r-sanitizer. It may be faster as well, especially if you have many cores.

@paleolimbot
Copy link
Member Author

paleolimbot commented Dec 14, 2021

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer test-fedora-r-clang-sanitizer

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Revision: f494d89

Submitted crossbow builds: ursacomputing/crossbow @ actions-1299

Task Status
test-fedora-r-clang-sanitizer Azure
test-ubuntu-18.04-r-sanitizer Azure

pitrou
pitrou approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @paleolimbot .

@pitrou pitrou closed this in 886a27b Dec 15, 2021
@ursabot
Copy link

ursabot commented Dec 15, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 0bfc641 and contender = 886a27b. 886a27b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@paleolimbot paleolimbot deleted the r-fix-duration branch December 9, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paleolimbot @jonkeane @pitrou @ursabot