-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-14899: [C++] implement GcsInputStream::GetMetadata #11791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14899: [C++] implement GcsInputStream::GetMetadata #11791
Conversation
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a suggestion
| result = fs->OpenInputStream(NotFoundObjectPath()); | ||
| EXPECT_EQ(result.status().code(), StatusCode::IOError); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also possible to add a simple roundtrip test between ToObjectMetadata and FromObjectMetadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (with some limitations, not all fields have public modifiers in gcs::ObjectMetadata)
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
|
Benchmark runs are scheduled for baseline = 996a08b and contender = bd4d1e6. bd4d1e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.