-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-13643: [C++][Compute] Implement outer join with support for residual predicates #11579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
0754d39 to
718f2a3
Compare
|
The CI failure seems to be a failure with failing to download python 3.1 (https://discuss.python.org/t/disappearing-macos-packages-on-python-org/11737), which is unrelated to this PR. |
718f2a3 to
abe7b48
Compare
bkietz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I'm still reading this PR, but I've got a few minor comments now
71f5bd6 to
8e01ed9
Compare
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I'm surprised this only required one additional test as there is a fair amount of nuance here but it is possible that some of these situations are being covered by the existing tests.
3c8db0c to
9ef81ec
Compare
|
The failures seem to be due to conda having a bad time: Don't think it's related to me. I'll try rebasing in a couple days and maybe the checks will pass. |
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits from me.
|
@bkietz did you want to look over this one more time? Otherwise I think we can merge. |
439e8ff to
a3ea744
Compare
76613e3 to
762695a
Compare
These failures don't appear to be me. |
Hmm, it seems this PR modifies the parquet-testing submodule - perhaps it needs to be rebased/something happened during the last rebase? |
762695a to
10e9613
Compare
|
Yeah that seems like what happened. I guess I still need some practice with rebasing 😅 I went with the nuclear option and squashed my commits and removed the change to the testing directory, so hopefully it'll be good now. |
|
Ok, looks like these last two failures/timeouts are not related. Thanks for the updates! |
|
Benchmark runs are scheduled for baseline = 72f7fbe and contender = 4913352. 4913352 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Implements residual predicates on hash join