Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Oct 28, 2021

No description provided.

@github-actions
Copy link

@coryan coryan marked this pull request as ready for review October 28, 2021 17:48
@kou
Copy link
Member

kou commented Oct 28, 2021

@github-actions crossbow submit -g nightly

@github-actions
Copy link

Revision: 7f69cf410b42194a7fffb4687835a08c4bf3c3f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-1059

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 TravisCI
amazon-linux-2-amd64 Github Actions
centos-7-amd64 Github Actions
centos-8-amd64 Github Actions
centos-8-arm64 TravisCI
conda-clean Azure
conda-linux-gcc-py310-arm64 Azure
conda-linux-gcc-py310-cuda Azure
conda-linux-gcc-py36-arm64 Azure
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py36-cuda Azure
conda-linux-gcc-py37-arm64 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-linux-gcc-py37-cuda Azure
conda-linux-gcc-py38-arm64 Azure
conda-linux-gcc-py38-cpu Azure
conda-linux-gcc-py38-cuda Azure
conda-linux-gcc-py39-arm64 Azure
conda-linux-gcc-py39-cpu Azure
conda-linux-gcc-py39-cuda Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
conda-win-vs2017-py38 Azure
conda-win-vs2017-py39 Azure
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 TravisCI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 TravisCI
debian-buster-amd64 Github Actions
debian-buster-arm64 TravisCI
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
test-build-vcpkg-win Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.10 Github Actions
test-conda-python-3.6 Github Actions
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
test-debian-11-cpp Github Actions
test-debian-11-go-1.15 Azure
test-debian-11-python-3 Azure
test-debian-c-glib Github Actions
test-debian-ruby Github Actions
test-fedora-33-cpp Github Actions
test-fedora-33-python-3 Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-auto Azure
test-r-depsource-system Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-ubuntu-21.04 Github Actions
test-r-versions Github Actions
test-skyhook-integration Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-18.04-python-3 Azure
test-ubuntu-18.04-r-sanitizer Azure
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-20.10-docs Azure
test-ubuntu-c-glib Github Actions
test-ubuntu-default-docs Azure
test-ubuntu-ruby Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 TravisCI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 TravisCI
ubuntu-hirsute-amd64 Github Actions
ubuntu-hirsute-arm64 TravisCI
ubuntu-impish-amd64 Github Actions
ubuntu-impish-arm64 TravisCI
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@coryan
Copy link
Contributor Author

coryan commented Nov 2, 2021

Ping? Is there something else I need to do here?

@pitrou pitrou requested a review from kszucs November 3, 2021 12:34
@kou
Copy link
Member

kou commented Nov 4, 2021

It seems that this is a problem.

https://github.com/ursacomputing/crossbow/runs/4039103923?check_suite_focus=true#step:6:1189

#12 14.69 Package google-cloud-cpp does not have a storage feature

I probably do not understand how these are used, probably something for
later.
@coryan
Copy link
Contributor Author

coryan commented Nov 4, 2021

I see. The code checks out version 2021.04.30:

arrow/.env

Line 75 in faf8b82

VCPKG="2021.04.30"

That version does not include the storage feature, neither does the latest tag at 2021.05.12.

How do you feel about pinning vcpkg to a specific SHA, but not to a tag?

@kou
Copy link
Member

kou commented Nov 4, 2021

How do you feel about pinning vcpkg to a specific SHA, but not to a tag?

@ianmcook @kszucs What do you think about this?

@kszucs
Copy link
Member

kszucs commented Nov 4, 2021

We used to pin specific SHAs beforehand, so it's fine.

@coryan
Copy link
Contributor Author

coryan commented Nov 4, 2021

Thanks, I have updated this PR accordingly. I also sent ursacomputing/crossbow#6 for review, I am not sure which one should be merged first, please let me know if I should help with that.

@kszucs
Copy link
Member

kszucs commented Nov 4, 2021

Thanks! Since it affects the build cache we should wait for the 6.0.1 patch release with both of the PRs.

(technically we could already merge the crossbow PR because the vcpkg version is included in the cache key, but the github actions cache eviction policy may remove the previous artifacts)

@kszucs
Copy link
Member

kszucs commented Nov 22, 2021

Merged the crossbow PR. I'm going to rebuild and push the windows docker images for the windows wheels then we can submit the crossbow jobs here.

@kszucs
Copy link
Member

kszucs commented Nov 23, 2021

After fixing the vcpkg/ports.patch I'm getting a vcpkg dependency problem on windows:

✖ REPO=ghcr.io/ursacomputing/arrow PYTHON=3.10 archery docker build --using-docker-cli python-wheel-windows-vs2017
Error response from daemon: manifest unknown
docker pull ghcr.io/ursacomputing/arrow:python-3.10-wheel-windows-vs2017-vcpkg-9675ab15def74a0b96d954bddc7ddabb42c92452 exited with non-zero exit code 1
Sending build context to Docker daemon  453.1kB
Step 1/19 : FROM abrarov/msvc-2017:2.10.0
 ---> 48bb8164f545
Step 2/19 : RUN choco install --no-progress -r -y cmake --installargs 'ADD_CMAKE_TO_PATH=System' &&     choco install --no-progress -r -y gzip wget ninja
 ---> Using cache
 ---> 84da6558371c
Step 3/19 : RUN setx path "%path%;C:\Program Files\Git\usr\bin"
 ---> Using cache
 ---> 744f355e6df4
Step 4/19 : ARG vcpkg
 ---> Using cache
 ---> 6fd7cae10c08
Step 5/19 : RUN git clone https://github.com/Microsoft/vcpkg &&     vcpkg\bootstrap-vcpkg.bat -disableMetrics &&     setx PATH "%PATH%;C:\vcpkg" &&     git -C vcpkg checkout %vcpkg%
 ---> Using cache
 ---> a85f4b3090f6
Step 6/19 : COPY ci/vcpkg/*.patch      ci/vcpkg/*windows*.cmake      arrow/ci/vcpkg/
 ---> Using cache
 ---> cdc9fbfb7e6e
Step 7/19 : RUN cd vcpkg && git apply --ignore-whitespace C:/arrow/ci/vcpkg/ports.patch
 ---> Using cache
 ---> c93972ad92dc
Step 8/19 : ARG build_type=release
 ---> Using cache
 ---> c130e80c70b8
Step 9/19 : ENV CMAKE_BUILD_TYPE=${build_type}     VCPKG_OVERLAY_TRIPLETS=C:\\arrow\\ci\\vcpkg     VCPKG_DEFAULT_TRIPLET=x64-windows-static-md-${build_type}     VCPKG_FEATURE_FLAGS=-manifests
 ---> Using cache
 ---> e7a18a9e6535
Step 10/19 : RUN vcpkg install --clean-after-build         abseil         aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer]         boost-filesystem         boost-multiprecision         boost-system         brotli         bzip2         c-ares         curl         flatbuffers         gflags         glog         google-cloud-cpp[core,storage]         grpc         lz4         openssl         orc         protobuf         rapidjson         re2         snappy         thrift         utf8proc         zlib         zstd
 ---> Running in 3c89420370c9
Computing installation plan...
Error: aws-checksums[core] is only supported on '!arm & !windows'
The command 'cmd /S /C vcpkg install --clean-after-build         abseil         aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer]         boost-filesystem         boost-multiprecision         boost-system         brotli         bzip2         c-ares         curl         flatbuffers         gflags         glog         google-cloud-cpp[core,storage]         grpc         lz4         openssl         orc         protobuf         rapidjson         re2         snappy         thrift         utf8proc         zlib         zstd' returned a non-zero code: 1
Error: docker build --build-arg BUILDKIT_INLINE_CACHE=1 --build-arg python=3.10 --build-arg vcpkg=9675ab15def74a0b96d954bddc7ddabb42c92452 -f ci/docker/python-wheel-windows-vs2017.dockerfile -t ghcr.io/ursacomputing/arrow:python-3.10-wheel-windows-vs2017-vcpkg-9675ab15def74a0b96d954bddc7ddabb42c92452 /Users/kszucs/Workspace/arrow exited with non-zero exit code 1

It has been already resolved upstream, so I pinned the HEAD commit.

@kszucs
Copy link
Member

kszucs commented Nov 24, 2021

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: 47e8935

Submitted crossbow builds: ursacomputing/crossbow @ actions-1170

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 24, 2021

New changes:

  • bumped the vcpkg version to make the aws-sdk-cpp compile on windows
  • updated to use the install_vcpkg.sh script everywhere (including the windows docker images)
  • removed the duplicated vcpkg versions across the build configs, now it uses VCPKG version from .env

Still, We have several problems here:

  1. CMake 3.22.0 has a regression causing issue with AWSSDKConfig.cmake. We need to pin 3.21.4 both on macOS and manylinux.
  2. Manylinux2010 doesn't have realpath so we need to switch to readlink -f in the install_vcpkg.sh script.
  3. The vcpkg installer now downloads a prebuilt binary instead of compiling the vcpkg tool itself locally but the binary links with >glibc 2.14 and the manylinux2010 image has glibc=2.12. I patched the bootstrap.sh script to force build vcpkg but getting many ambiguous calls errors during compilation. @pitrou perhaps it would be the right time to drop the EOL manylinux2010 packages.
  4. The aws-sdk-cpp packages are restricted to non-arm architectures despite that earlier versions used to work. I assume patching the port files with a new constraint would work.

@github-actions
Copy link

Revision: 86daacc

Submitted crossbow builds: ursacomputing/crossbow @ actions-1200

Task Status
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit wheel-macos-big-sur-*-universal2

@github-actions
Copy link

Revision: c9bfce9

Submitted crossbow builds: ursacomputing/crossbow @ actions-1201

Task Status
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: f8c7af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-1202

Task Status
wheel-macos-big-sur-cp39-universal2 Github Actions

@github-actions
Copy link

Revision: f8c7af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-1203

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions
Copy link

Revision: 0662793

Submitted crossbow builds: ursacomputing/crossbow @ actions-1205

Task Status
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions
Copy link

Revision: 283d7a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1206

Task Status
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Nov 26, 2021

@github-actions crossbow submit -g wheel

@github-actions
Copy link

Revision: 283d7a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1207

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@coryan
Copy link
Contributor Author

coryan commented Nov 26, 2021

@coryan we don't yet have python bindings for GCS, right?

If you mean in Arrow, then no, they do not exist yet. I had no plans to create them either.

@pitrou
Copy link
Member

pitrou commented Nov 26, 2021

If you mean in Arrow, then no, they do not exist yet. I had no plans to create them either.

That's something that other contributors can do :-)

@kszucs
Copy link
Member

kszucs commented Nov 29, 2021

Added a note about enabling the GCS feature in the wheels for https://issues.apache.org/jira/browse/ARROW-14892

@pitrou this should be ready for review then

vcpkg install --clean-after-build \
abseil \
aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer] \
boost-filesystem \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we still need boost-filesystem here? AFAIR the dependency is only for unit tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to create a follow-up to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kszucs kszucs closed this in 2233ac5 Dec 1, 2021
@ursabot
Copy link

ursabot commented Dec 1, 2021

Benchmark runs are scheduled for baseline = 736a69e and contender = 2233ac5. 2233ac5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan coryan deleted the ARROW-14171-add-google-cloud-cpp-package branch December 1, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants