-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-14171: [C++][Python][Packaging] Upgrade VCPKG version and add google-cloud-cpp dependency #11569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14171: [C++][Python][Packaging] Upgrade VCPKG version and add google-cloud-cpp dependency #11569
Conversation
|
@github-actions crossbow submit -g nightly |
|
Revision: 7f69cf410b42194a7fffb4687835a08c4bf3c3f0 Submitted crossbow builds: ursacomputing/crossbow @ actions-1059 |
|
Ping? Is there something else I need to do here? |
|
It seems that this is a problem. https://github.com/ursacomputing/crossbow/runs/4039103923?check_suite_focus=true#step:6:1189 |
I probably do not understand how these are used, probably something for later.
|
I see. The code checks out version Line 75 in faf8b82
That version does not include the How do you feel about pinning vcpkg to a specific SHA, but not to a tag? |
|
We used to pin specific SHAs beforehand, so it's fine. |
|
Thanks, I have updated this PR accordingly. I also sent ursacomputing/crossbow#6 for review, I am not sure which one should be merged first, please let me know if I should help with that. |
|
Thanks! Since it affects the build cache we should wait for the 6.0.1 patch release with both of the PRs. (technically we could already merge the crossbow PR because the vcpkg version is included in the cache key, but the github actions cache eviction policy may remove the previous artifacts) |
|
Merged the crossbow PR. I'm going to rebuild and push the windows docker images for the windows wheels then we can submit the crossbow jobs here. |
|
After fixing the It has been already resolved upstream, so I pinned the HEAD commit. |
|
@github-actions crossbow submit -g wheel |
|
Revision: 47e8935 Submitted crossbow builds: ursacomputing/crossbow @ actions-1170 |
|
New changes:
Still, We have several problems here:
|
|
Revision: 86daacc Submitted crossbow builds: ursacomputing/crossbow @ actions-1200
|
|
@github-actions crossbow submit wheel-macos-big-sur-*-universal2 |
|
Revision: c9bfce9 Submitted crossbow builds: ursacomputing/crossbow @ actions-1201
|
|
@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2 |
|
@github-actions crossbow submit -g wheel |
|
Revision: f8c7af4 Submitted crossbow builds: ursacomputing/crossbow @ actions-1202
|
|
Revision: f8c7af4 Submitted crossbow builds: ursacomputing/crossbow @ actions-1203 |
|
@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2 |
|
Revision: 0662793 Submitted crossbow builds: ursacomputing/crossbow @ actions-1205
|
|
@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2 |
|
Revision: 283d7a8 Submitted crossbow builds: ursacomputing/crossbow @ actions-1206
|
|
@github-actions crossbow submit -g wheel |
|
Revision: 283d7a8 Submitted crossbow builds: ursacomputing/crossbow @ actions-1207 |
If you mean in Arrow, then no, they do not exist yet. I had no plans to create them either. |
That's something that other contributors can do :-) |
|
Added a note about enabling the GCS feature in the wheels for https://issues.apache.org/jira/browse/ARROW-14892 @pitrou this should be ready for review then |
| vcpkg install --clean-after-build \ | ||
| abseil \ | ||
| aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer] \ | ||
| boost-filesystem \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we still need boost-filesystem here? AFAIR the dependency is only for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to create a follow-up to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Benchmark runs are scheduled for baseline = 736a69e and contender = 2233ac5. 2233ac5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.