ARROW-1591: C++: Xcode 9 is not correctly detected #1121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
commented
Sep 21, 2017
| # clang on Mac OS X, XCode 8. | ||
| elseif("${COMPILER_VERSION_FULL}" MATCHES ".*clang-9") | ||
| set(COMPILER_FAMILY "clang") | ||
| set(COMPILER_VERSION "4.0.0svn") |
Member
Author
There was a problem hiding this comment.
This is just guessing, I have not found any public source that clarifies this. At the moment, we're not using the version, only the family, so this should not matter that much.
Member
There was a problem hiding this comment.
OK, we can always revisit if this comes up
Member
|
Seems like something went wrong when installing the Sphinx docs requirements, causing a NumPy version conflict: https://travis-ci.org/apache/arrow/jobs/278165398#L9068 Unrelated to this change |
Member
Author
|
@wesm any idea on how to fix this? |
Member
|
It is probably related to a package update in conda-forge causing an issue with the package dependency graph. I will take a look |
wesm
approved these changes
Sep 21, 2017
| # clang on Mac OS X, XCode 8. | ||
| elseif("${COMPILER_VERSION_FULL}" MATCHES ".*clang-9") | ||
| set(COMPILER_FAMILY "clang") | ||
| set(COMPILER_VERSION "4.0.0svn") |
Member
There was a problem hiding this comment.
OK, we can always revisit if this comes up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.