ARROW-1590: [JS] Flow TS Table method generics #1120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@trxcllnt can you rebase on master? |
Contributor
Author
|
@wesm done |
Member
|
There are still some extra commits that should rebase out if you base against the current apache/master. I rebased some commits on the release branch and force-pushed master after 0.7.0 which is why there's an issue |
Contributor
Author
|
@wesm ok, I rebased and dropped the extra commits. |
Member
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Table generics to infer the types from the call site:
@wesm this PR also includes the fixes to the prepublish script I mentioned yesterday.