ARROW-1578: [C++] Run lint checks in Travis CI much earlier at before_script stage to fail faster #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib812f49e248540c7283a1e058f26925dbc36af00
xhochy
reviewed
Sep 20, 2017
cpp/src/arrow/buffer.h
Outdated
| class ARROW_EXPORT PoolBuffer : public ResizableBuffer { | ||
| public: | ||
| explicit PoolBuffer(MemoryPool* pool = nullptr); | ||
| PoolBuffer(MemoryPool* pool = nullptr); |
Member
Author
There was a problem hiding this comment.
This will fail the cpplint checks so I wanted to make sure that my changes have the desired effect of failing the builds fast
Change-Id: I249a02511b21b8dda43dc7e001cfcf4204fe9f21
xhochy
approved these changes
Sep 20, 2017
Change-Id: I69076c41dad6fd8754fc154748ce6bd90bb8a7b2
Member
Author
|
Pretty unsure why https://travis-ci.org/apache/arrow/jobs/277763849 failed |
Change-Id: I153daebbf521598fd88892b009e0b505fe60e350
Change-Id: I02dff04e3a9dd6eac7dec66e2809fe09a7b6c6fa
Change-Id: Ie388db2ce2e87905081457be4287927d7542fc40
Change-Id: Icd46f484474699096ffacbe7b4ca9be1fa80f6c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.