ARROW-13691: [C++] Support skip_nulls/min_count in VarianceOptions #11005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This builds on top of ARROW-13737 to avoid merge conflicts. Leaving in draft until then. |
b2d789f to
4b3f9dc
Compare
pitrou
reviewed
Aug 31, 2021
Member
pitrou
left a comment
There was a problem hiding this comment.
LGTM. A couple minor comments.
Member
There was a problem hiding this comment.
Isn't this exactly the same as AssertVarStdIsInvalid?
Member
There was a problem hiding this comment.
Should this be called all_valid for clarity?
pitrou
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.