Skip to content

Conversation

@cyb70289
Copy link
Contributor

@cyb70289 cyb70289 commented Aug 20, 2021

Merging one tdigest is a common case, current API is awkward to use.

@github-actions
Copy link

@cyb70289 cyb70289 marked this pull request as draft August 20, 2021 02:16
Merging one tdigest is a common case, current API is awkward to use.
@cyb70289 cyb70289 changed the title ARROW-13520: [C++] Simplify TDigest.Merge API ARROW-13520: [C++] Add TDigest API to merge one TDigest Aug 20, 2021
@cyb70289 cyb70289 marked this pull request as ready for review August 20, 2021 03:21
@cyb70289 cyb70289 requested a review from lidavidm August 20, 2021 03:21
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this cleanup!

@lidavidm lidavidm changed the title ARROW-13520: [C++] Add TDigest API to merge one TDigest ARROW-13682: [C++] Add TDigest API to merge one TDigest Aug 20, 2021
@github-actions
Copy link

@lidavidm lidavidm closed this in 4175533 Aug 20, 2021
@cyb70289 cyb70289 deleted the 13520-tdigest branch August 20, 2021 14:10
@cyb70289 cyb70289 restored the 13520-tdigest branch August 20, 2021 14:15
@cyb70289 cyb70289 deleted the 13520-tdigest branch August 20, 2021 14:15
@cyb70289
Copy link
Contributor Author

Thanks for creating a jira issue.
I created one for this pr. But obviously I messed it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants