ARROW-13311: [C++][Documentation] Document hash aggregate kernels #10887
Conversation
|
|
5e8e39a to
fd03cc7
Compare
|
Thanks for doing this @lidavidm! Could you rebase to fix the conflict then request a review? Thanks! |
pitrou
left a comment
There was a problem hiding this comment.
Thank you very much! Just a couple comments/questions.
|
I added an example and reworded things to talk about grouped aggregations, since this is part of the User Guide:
|
|
Updated wording/explanation of "hash_":
|
|
I pushed a number of minor changes. @nealrichardson @ianmcook Can you give this the final go when you're fine with the changes? |
Co-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Ian Cook <ianmcook@gmail.com>
Co-authored-by: Ian Cook <ianmcook@gmail.com>
ianmcook
left a comment
There was a problem hiding this comment.
LGTM! Thanks David and Antoine
docs/source/cpp/compute.rst
Outdated
| | hash_all | Unary | Boolean | Int64 | :struct:`ScalarAggregateOptions` | \(1) | | ||
| +---------------+-------+-------------+----------------+----------------------------------+-------+ | ||
| | hash_any | Unary | Any | Int64 | :struct:`ScalarAggregateOptions` | \(1) | |
There was a problem hiding this comment.
| | hash_all | Unary | Boolean | Int64 | :struct:`ScalarAggregateOptions` | \(1) | | |
| +---------------+-------+-------------+----------------+----------------------------------+-------+ | |
| | hash_any | Unary | Any | Int64 | :struct:`ScalarAggregateOptions` | \(1) | | |
| | hash_all | Unary | Boolean | Boolean | :struct:`ScalarAggregateOptions` | \(1) | | |
| +---------------+-------+-------------+----------------+----------------------------------+-------+ | |
| | hash_any | Unary | Boolean | Boolean | :struct:`ScalarAggregateOptions` | \(1) | |
?
At least, the non-hash versions of any/all only work on boolean input, and return booleans (didn't check for the hashed version)
There was a problem hiding this comment.
Ah you're right, I probably forgot to fix it up after copy-paste. I've fixed these rows (+ hash_count).
This adds a section about hash aggregates. Also, adds Kleene logic to the hash any/all kernels.