ARROW-13568: [Gandiva] Support null data type for gandiva. #10884
Conversation
…eature/gdv_null_type
|
@anthonylouisbsb Hi Anthony, could you help review this pr? Thanks in advance. |
| llvm::Value* LLVMGenerator::GetDataReference(llvm::Value* arg_addrs, int idx, | ||
| FieldPtr field) { | ||
| const std::string& name = field->name(); | ||
| llvm::Value* load = LoadVectorAtIndex(arg_addrs, idx, name); |
There was a problem hiding this comment.
Not sure. But should we add this null type to supported types so that dremio can see this null type as a supported type. there seems to be some code in llvm_types.h for supported types. But I do not know this well enough to know whether you have to add something to supported types, so that dremio knows that Gandiva can be used as a viable codegen for this.
There was a problem hiding this comment.
Thanks @rkavanap. Could you involve some guy familiar with dremio and help review this? If dremio might update code correspondingly, I think the change should be small.
|
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍 |
No description provided.