ARROW-13520: [C++] Implement hash_aggregate tdigest kernel #10860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyb70289
approved these changes
Aug 4, 2021
Comment on lines
+1359
to
+1360
| other_tdigest[0] = std::move(other->tdigests_[other_g]); | ||
| tdigests_[*g].Merge(&other_tdigest); |
Contributor
There was a problem hiding this comment.
I don't remember why but this api does looks awkward :(
Member
Author
There was a problem hiding this comment.
It might be worth considering whether Merge should take an iterator pair (and whether TDigest::Merge should also take an iterator pair or vector of pointers instead of a vector of structs).
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.