Skip to content

ARROW-13381: [C++] ArrayFromJSON doesn't work for float value dictionary type #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edponce wants to merge 1 commit into from
Closed

ARROW-13381: [C++] ArrayFromJSON doesn't work for float value dictionary type #10746

edponce wants to merge 1 commit into from

Conversation

@edponce
Copy link
Contributor

@edponce edponce commented Jul 19, 2021

This PR adds float/double cases for dictionary converter.

@github-actions
Copy link

github-actions bot commented Jul 19, 2021

https://issues.apache.org/jira/browse/ARROW-13381

@edponce edponce mentioned this pull request Jul 19, 2021
Closed
@lidavidm
Copy link
Member

lidavidm commented Jul 19, 2021

Thanks for the quick fix.

What does this have to do with Flight?

@nirandaperera
Copy link
Contributor

nirandaperera commented Jul 19, 2021

Thanks for the quick fix.

What does this have to do with Flight?

I added Flight because I thought this needs to be added in the Flight code. 😁

@nirandaperera
Copy link
Contributor

nirandaperera commented Jul 19, 2021

Thanks @edponce

@edponce edponce changed the title ARROW-13381: [C++][Flight] ArrayFromJSON doesn't work for float value dictionary type ARROW-13381: [C++] ArrayFromJSON doesn't work for float value dictionary type Jul 19, 2021
lidavidm
lidavidm approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lidavidm
Copy link
Member

lidavidm commented Jul 19, 2021

MacOS failure looks unrelated.

@lidavidm lidavidm closed this in 5832c73 Jul 19, 2021
@asfimport asfimport mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edponce @lidavidm @nirandaperera