ARROW-13171: [R] Add binding for str_pad() #10638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Have opened a ticket for the centre padding functions as C++/R ways of doing spaces don't match and can't be configured to currently: https://issues.apache.org/jira/browse/ARROW-13234 |
Member
|
See #10639. Sorry, I thought I had checked against the Python behavior at least, apparently not. |
Member
Author
Wow, that was fast, thanks! :) |
4140fbc to
59f5f3c
Compare
Member
Author
|
Have now updated this PR to no longer skip a test, as the C++ code has changed and it now matches the R/stringr implementation. |
ianmcook
reviewed
Jul 6, 2021
ianmcook
reviewed
Jul 6, 2021
Co-authored-by: Ian Cook <ianmcook@gmail.com>
ianmcook
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.