-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-12868: [R] Bindings for find_substring and find_substring_regex #10588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a7b2fc to
b974ef1
Compare
|
Do you think there's any way to define a I think the answer is no because this would require returning a struct column, and that's not possible? Is this limitation related to the issue in ARROW-13149 that @jonkeane was discussing recently? |
|
On the struct column front, returning a struct column is totally fine right now (making a struct from R is a bit more complicated though). However, right now more likely than not that struct will bet automatically turned in to a tibble (or at least that will be attempted) when pulling it into R. ARROW-13149 aims to make it so that structs will return as named lists instead of always being converted into tibbles automatically. All of this is to say, I think it would be totally fine for this to a return a struct right now (so long as it doesn't return something super bad when attempting to be turned into a tibble) and so long as we are ok with the R side of what the results come out as (hopefully) changing soon |
|
Cool, thanks @jonkeane. IIUC, to achieve this we would need to use the |
|
I created ARROW-13165 to follow up on the |
Yes, if that sounds 👍 to you |
|
Sounds like a plan! |
|
Meanwhile it looks like ARROW-13157 has a PR, so if we wait a few days for that to get merged, then we can remove the skipped test in this PR before we merge it. |
Let's just do that then! |
a0ea147 to
9f4b3d7
Compare
|
The PR for ARROW-13157 is merged, so I rebased and removed the skipped test. I'll merge when the CI is green. |
|
I incorporated the |
No description provided.