ARROW-11514: [R][C++] Bindings for paste(), paste0(), str_c() #10547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcook
commented
Jun 18, 2021
ianmcook
commented
Jun 18, 2021
ianmcook
commented
Jun 18, 2021
Member
|
Ah ok, thanks for confirming. Though, if there's another behavior we need for separators to match R's better we can extend the kernel.
|
lidavidm
reviewed
Jun 18, 2021
Co-authored-by: David Li <li.davidm96@gmail.com>
Member
nealrichardson
left a comment
There was a problem hiding this comment.
A couple of minor notes but otherwise LGTM
nealrichardson
approved these changes
Jun 23, 2021
Member
Author
|
@lidavidm before I merge this: could you take a quick look at the failing CI checks and confirm that they seem unrelated to the C++ changes here? Thanks! |
Member
|
You should be fine to merge. AppVeyor is because of ARROW-13134 |
This was referenced Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the string concatenation functions
paste(),paste0(), andstr_c()in dplyr verbs. Only the non-aggregatingcollapse = NULLcase is currently supported.