ARROW-12717: [C++][Python] Add find_substring kernel #10353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyb70289
approved these changes
May 19, 2021
Contributor
cyb70289
left a comment
There was a problem hiding this comment.
LGTM, +1.
A dedicated FindSubstringOptions looks better but can be postponed when we want to implement rfind.
Member
Author
|
A thought I had is that we could/should support binary/large_binary too. And, we may want to output int32 instead of int64 for the non-large_ arrays. |
Member
Author
|
Updated to support binary/large_binary and to output int32 for non-large types. I'm still postponing regex find/rfind for a different issue. Though, I'm not sure if we want rfind to be an option of this kernel or its own kernel. |
Member
Author
|
Rebased and fixed conflicts. |
Member
Member
Author
|
Let's merge this one first, then I'll fix up the other (though it's no big deal either way). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very simple lfind kernel. If the substring is not found, -1 is reported. Nulls are propagated. Regexes are not supported, nor is rfind.