Skip to content

[Format] Serialization of fp16 literals via Substrait is under-defined #47846

@westonpace

Description

@westonpace

Describe the enhancement requested

Currently we state:

  # fp16 literals are encoded as user defined literals with
  # a google.protobuf.UInt32Value message where the lower 16 bits are
  # the fp16 value.

I think "lower 16 bits of UInt32Value" is well defined. However, it is not clear how the fp16 value should be encoded. Should the upper byte of the fp16 value go in the lowest 8 bits of the UInt32Value or the highest 8 bits of the UInt32Value?

Hopefully this is not controversial and just under-specified. I will add a PR to adopt little-endian encoding.

Component(s)

Format

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions