Skip to content

[CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46726

@hiroyuki-sato

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

  • SC2046 -- Quote this to prevent word splitt...
  • SC2206 -- Quote to prevent word splitting/g...
  • SC2086 -- Double quote to prevent globbing ...
In ci/scripts/conan_build.sh line 32:
  conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
                                         ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 33:
  conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
                                             ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 34:
  conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
                                            ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 37:
  conan_args+=(--options arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 40:
  conan_args+=(--options arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 43:
  conan_args+=(--options arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                                 ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 44:
  conan_args+=(--options arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                           ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 45:
  conan_args+=(--options arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                               ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 46:
  conan_args+=(--options arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                          ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 49:
  conan_args+=(--options arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 52:
  conan_args+=(--options arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC})
                                               ^--------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 55:
  conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_WITH_JSON})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 58:
  conan_args+=(--options arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 61:
  conan_args+=(--options arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 64:
  conan_args+=(--options arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 67:
version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \
                                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
version=$(grep '^set(ARROW_VERSION ' "${ARROW_HOME}"/cpp/CMakeLists.txt | \


In ci/scripts/conan_build.sh line 69:
conan_args+=(--version ${version})
                       ^--------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 72:
rm -rf ${build_dir}/conan || sudo rm -rf ${build_dir}/conan
       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${build_dir}"/conan || sudo rm -rf "${build_dir}"/conan


In ci/scripts/conan_build.sh line 73:
mkdir -p ${build_dir}/conan || sudo mkdir -p ${build_dir}/conan
         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "${build_dir}"/conan || sudo mkdir -p "${build_dir}"/conan


In ci/scripts/conan_build.sh line 74:
if [ -w ${build_dir} ]; then
        ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ -w "${build_dir}" ]; then


In ci/scripts/conan_build.sh line 75:
  cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 77:
  sudo cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
             ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 78:
  sudo chown -R $(id -u):$(id -g) ${build_dir}/conan/
                ^------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^------^ SC2046 (warning): Quote this to prevent word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo chown -R $(id -u):$(id -g) "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 80:
cd ${build_dir}/conan/all
   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cd "${build_dir}"/conan/all

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Component(s)

Continuous Integration

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions