-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[C++] Unifying simd header includings #44249
Copy link
Copy link
Closed
Description
Describe the enhancement requested
Some of simd-related files are including concrete system headers such as:
arrow/cpp/src/arrow/acero/bloom_filter.h
Lines 20 to 22 in 6f64af5
| #if defined(ARROW_HAVE_RUNTIME_AVX2) | |
| # include <immintrin.h> | |
| #endif |
However I see that https://github.com/apache/arrow/blob/6f64af54ea3662b7e1685b84a81429df14beace1/cpp/src/arrow/util/simd.h seems to be a centralized header to sort out all the platform-specific checks. Besides, I think it is a good place to put universal definitions - e.g. working around certain compiler bugs like what #44116 did - to be visible to all simd source files.
Therefore I think we can unify the simd header inclusion by utilizing simd.h.
Component(s)
C++
Reactions are currently unavailable
Metadata
Metadata
Assignees
Type
Fields
Give feedbackNo fields configured for issues without a type.