Skip to content

[C++][Parquet] Minor: Enhance style for creating page writer #40767

@mapleFU

Description

@mapleFU

Describe the enhancement requested

    std::unique_ptr<PageWriter> pager;
    if (!codec_options) {
      pager = PageWriter::Open(sink_, properties_->compression(path), col_meta,
                               row_group_ordinal_, static_cast<int16_t>(column_ordinal),
                               properties_->memory_pool(), false, meta_encryptor,
                               data_encryptor, properties_->page_checksum_enabled(),
                               ci_builder, oi_builder, CodecOptions());
    } else {
      pager = PageWriter::Open(sink_, properties_->compression(path), col_meta,
                               row_group_ordinal_, static_cast<int16_t>(column_ordinal),
                               properties_->memory_pool(), false, meta_encryptor,
                               data_encryptor, properties_->page_checksum_enabled(),
                               ci_builder, oi_builder, *codec_options);
    }

This kind of code is so ugly and bug prone (see #36829 ). I prefer to using one PageWriter::Open here

Component(s)

C++, Parquet

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions