-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Description
TransferBitmap has two template parameters of bool type with four combinations.
Change them to function parameters can reduce code size. I think "restore_trailing_bits" cannot impact performance. "invert_bits" needs benchmark.
Also, bool parameter is hard to figure out at caller side, better to use meaningful defines.
Reporter: Yibo Cai / @cyb70289
Assignee: Yibo Cai / @cyb70289
Related issues:
- [C++] Reduce shared library / binary code size (umbrella issue) (is related to)
PRs and other links:
Note: This issue was originally created as ARROW-8974. Please see the migration documentation for further details.