Skip to content

Commit 94b3423

Browse files
thisisnickou
andauthored
GH-35181: [R] Bump R package version number in versions.json (#35132)
This PR corrects a missed R package version number increase * Closes: #35181 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
1 parent 9888ac3 commit 94b3423

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

dev/release/01-prepare-test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,10 @@ def test_version_pre_tag
243243
[
244244
"- \"name\": \"#{@previous_version}.9000 (dev)\",",
245245
"+ \"name\": \"#{@release_version}.9000 (dev)\",",
246-
"- \"name\": \"#{@previous_version} (release)\",",
246+
"- \"name\": \"#{@previous_r_version} (release)\",",
247247
"+ \"name\": \"#{@release_version} (release)\",",
248248
"+ {",
249-
"+ \"name\": \"#{@previous_version}\",",
249+
"+ \"name\": \"#{@previous_r_version}\",",
250250
"+ \"version\": \"#{@previous_compatible_version}/\"",
251251
"+ },",
252252
]
@@ -261,7 +261,7 @@ def test_version_pre_tag
261261
[
262262
"- \"name\": \"#{@previous_version}.9000 (dev)\",",
263263
"+ \"name\": \"#{@release_version}.9000 (dev)\",",
264-
"- \"name\": \"#{@previous_version} (release)\",",
264+
"- \"name\": \"#{@previous_r_version} (release)\",",
265265
"+ \"name\": \"#{@release_version} (release)\",",
266266
]
267267
],

dev/release/post-11-bump-versions-test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,10 @@ def test_version_post_tag
190190
[
191191
"- \"name\": \"#{@previous_version}.9000 (dev)\",",
192192
"+ \"name\": \"#{@release_version}.9000 (dev)\",",
193-
"- \"name\": \"#{@previous_version} (release)\",",
193+
"- \"name\": \"#{@previous_r_version} (release)\",",
194194
"+ \"name\": \"#{@release_version} (release)\",",
195195
"+ {",
196-
"+ \"name\": \"#{@previous_version}\",",
196+
"+ \"name\": \"#{@previous_r_version}\",",
197197
"+ \"version\": \"#{@previous_compatible_version}/\"",
198198
"+ },",
199199
],
@@ -208,7 +208,7 @@ def test_version_post_tag
208208
[
209209
"- \"name\": \"#{@previous_version}.9000 (dev)\",",
210210
"+ \"name\": \"#{@release_version}.9000 (dev)\",",
211-
"- \"name\": \"#{@previous_version} (release)\",",
211+
"- \"name\": \"#{@previous_r_version} (release)\",",
212212
"+ \"name\": \"#{@release_version} (release)\",",
213213
],
214214
],

dev/release/test-helper.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ def detect_versions
130130
else
131131
@previous_compatible_version = nil
132132
end
133+
r_versions = top_dir + "r" + "pkgdown" + "assets" + "versions.json"
134+
@previous_r_version = r_versions.read[/"name": "(.+?) \(release\)"/, 1]
133135
end
134136

135137
def compute_so_version(version)

r/pkgdown/assets/versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "dev/"
55
},
66
{
7-
"name": "11.0.0 (release)",
7+
"name": "11.0.0.3 (release)",
88
"version": ""
99
},
1010
{

0 commit comments

Comments
 (0)