Skip to content

Commit 7daee1c

Browse files
committed
address comment
1 parent ddd0cde commit 7daee1c

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

cpp/src/parquet/encoding.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,10 @@ class Decoder {
256256
// Sets the data for a new page. This will be called multiple times on the same
257257
// decoder and should reset all internal state.
258258
//
259-
// In current implementations, `num_values` is the `num_values` field in the
260-
// data page header, which may greater than the number of values in the data
261-
// buffer.
259+
// `num_values` comes from the data page header, and may be greater than the number of
260+
// physical values in the data buffer if there are some omitted (null) values.
261+
// `len`, on the other hand, is the size in bytes of the data buffer and
262+
// directly relates to the number of physical values.
262263
virtual void SetData(int num_values, const uint8_t* data, int len) = 0;
263264

264265
// Returns the number of values left (for the last call to SetData()). This is

0 commit comments

Comments
 (0)