GH-49156: [Python] Require GIL for string comparison (#49161)

raulcd · raulcd · commit 147bcd6d8f3f · 2026-02-06T12:31:07.000+01:00
### Rationale for this change With Cython 3.3.0.a0 this failed. After some discussion it seems that this should have always had to require the GIL. ### What changes are included in this PR? Moving statement out of the `with nogil` context manager. ### Are these changes tested? Existing CI builds pyarrow. ### Are there any user-facing changes? No * GitHub Issue: #49156 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
diff --git a/python/pyarrow/table.pxi b/python/pyarrow/table.pxi
@@ -6316,8 +6316,8 @@ def concat_tables(tables, MemoryPool memory_pool=None, str promote_options="none
         "default" if promote_options == "none" else promote_options
     )
 
+    options.unify_schemas = promote_options != "none"
     with nogil:
-        options.unify_schemas = promote_options != "none"
         c_result_table = GetResultValue(
             ConcatenateTables(c_tables, options, pool))
 

Original file line number	Diff line number	Diff line change
`@@ -6316,8 +6316,8 @@ def concat_tables(tables, MemoryPool memory_pool=None, str promote_options="none`
`6316`	`6316`	`"default" if promote_options == "none" else promote_options`
`6317`	`6317`	`)`
`6318`	`6318`
	`6319`	`+ options.unify_schemas = promote_options != "none"`
`6319`	`6320`	`with nogil:`
`6320`		`- options.unify_schemas = promote_options != "none"`
`6321`	`6321`	`c_result_table = GetResultValue(`
`6322`	`6322`	`ConcatenateTables(c_tables, options, pool))`
`6323`	`6323`