bugfix(CLI): if the user used default token and allow any IP to acces…#2244
Merged
moonming merged 7 commits intoapache:masterfrom Sep 22, 2020
membphis:default-token-4
Merged
bugfix(CLI): if the user used default token and allow any IP to acces…#2244moonming merged 7 commits intoapache:masterfrom membphis:default-token-4
moonming merged 7 commits intoapache:masterfrom
membphis:default-token-4
Conversation
…s Admin API, will show a WARNING message.
moonming
requested changes
Sep 17, 2020
moonming
reviewed
Sep 17, 2020
bin/apisix
Outdated
| end | ||
|
|
||
|
|
||
| local is_checked_admin_key |
Member
There was a problem hiding this comment.
is_checked_admin_key is confusing, please take a better name.
Member
Author
There was a problem hiding this comment.
checked_admin_key, any better name suggestions?
moonming
reviewed
Sep 18, 2020
bin/apisix
Outdated
Comment on lines
+855
to
+856
| help:format([[WARNING: using fixed API token has security risk, ]] | ||
| .. [[please modify "admin_key" in conf/config.yaml.]]), |
Member
There was a problem hiding this comment.
moonming
approved these changes
Sep 22, 2020
nic-chen
approved these changes
Sep 22, 2020
moonming
approved these changes
Sep 22, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s Admin API,
will show a WARNING message.
What this PR does / why we need it:
if the user used the default token and allow any IP to access Admin API,
will show a WARNING message.
Pre-submission checklist: