Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jun 25, 2020

It is slower to call e.g. dict() than using the empty literal, because the name dict must be looked up in the global scope in case it has been rebound. Same for the other two types like list() and tuple().


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from turbaszek June 25, 2020 13:29
@boring-cyborg boring-cyborg bot added area:dev-tools area:logging area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Jun 25, 2020
@turbaszek
Copy link
Member

@kaxil should we have a pre-commit check for that?

@kaxil
Copy link
Member Author

kaxil commented Jun 25, 2020

@kaxil should we have a pre-commit check for that?

Done in 9e418d4 :)

@kaxil kaxil merged commit 87fdbd0 into apache:master Jun 25, 2020
@kaxil kaxil deleted the fix-literal-fn branch June 25, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:logging area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants