Add example dag and system test for LocalFilesystemToGCSOperator #9043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
reviewed
May 29, 2020
Member
There was a problem hiding this comment.
Suggested change
| os.remove(PATH_TO_UPLOAD_FILE) | |
| self.delete_gcs_bucket(BUCKET_NAME) | |
| self.delete_gcs_bucket(BUCKET_NAME) | |
| os.remove(PATH_TO_UPLOAD_FILE) |
Just in case the file was deleted by something. It's better to have a dangling file than a bucket 😃
turbaszek
approved these changes
May 29, 2020
Member
|
@ephraimbuddy can you please rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes one of the issues in #8280
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.