-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Create guide for Dataproc Operators #9037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
turbaszek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Only few suggestions
turbaszek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix the docs I think. The problem is that referenced code is not indented (those fragments are not definied inside DAG context manager).
|
@joppevos can you adjust tests? We've got test that checks that guides are not missing... |
|
Thanks @joppevos ! |
A simple guide based on the example_dataproc file. Addressing this issue
notes/qs
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.