Skip to content

Add system test and docs for Facebook Ads operators #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mik-laj merged 4 commits into from
May 3, 2020
Merged

Add system test and docs for Facebook Ads operators #8503

mik-laj merged 4 commits into from
May 3, 2020

Conversation

@randr97
Copy link
Contributor

@randr97 randr97 commented Apr 21, 2020

Make sure to mark the boxes below before creating PR: [x]

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

mik-laj
mik-laj reviewed Apr 21, 2020
View reviewed changes
@randr97 randr97 force-pushed the Facebook_System_Test branch 2 times, most recently from 9ab4289 to 776866b Compare April 27, 2020 03:33
@randr97 randr97 requested a review from mik-laj April 27, 2020 08:11
@mik-laj
Copy link
Member

mik-laj commented Apr 27, 2020

I have run these tests and there are two minor problems.

  • The bucket is not created or deleted;
  • The BigQuery is not deleted.

@randr97
Copy link
Contributor Author

randr97 commented Apr 28, 2020 •
edited
Loading

I have run these tests and there are two minor problems.

  • The bucket is not created or deleted;
  • The BigQuery is not deleted.

Will add the create bucket and delete BigQ operator.
Thanks @mik-laj :)

@randr97 randr97 force-pushed the Facebook_System_Test branch from 776866b to 9551618 Compare April 28, 2020 21:44
@randr97 randr97 changed the title Facebook system test [WIP] Facebook system test Apr 28, 2020
@randr97 randr97 changed the title [WIP] Facebook system test [DONT MERG] Facebook system test Apr 28, 2020
@randr97 randr97 changed the title [DONT MERG] Facebook system test Facebook system test Apr 28, 2020
@randr97 randr97 force-pushed the Facebook_System_Test branch from 53374bd to 17b26db Compare April 29, 2020 20:23
@randr97 randr97 force-pushed the Facebook_System_Test branch from 17b26db to b5aaceb Compare April 29, 2020 21:44
@randr97 randr97 requested a review from mik-laj April 30, 2020 07:48
@mik-laj mik-laj changed the title Facebook system test Add system tests and docs for Facebook Ads operators May 3, 2020
@mik-laj mik-laj changed the title Add system tests and docs for Facebook Ads operators Add system test and docs for Facebook Ads operators May 3, 2020
@mik-laj mik-laj merged commit bc45fa6 into apache:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mik-laj mik-laj mik-laj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@randr97 @mik-laj