Allow multiple extra_packages in Dataflow #8394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
approved these changes
Apr 19, 2020
Member
turbaszek
left a comment
There was a problem hiding this comment.
Small suggestions otherwise LGTM
Comment on lines
695
to
696
| elif isinstance(value, bool): | ||
| if value: # pylint: disable=too-many-nested-blocks |
Member
There was a problem hiding this comment.
Suggested change
| elif isinstance(value, bool): | |
| if value: # pylint: disable=too-many-nested-blocks | |
| elif isinstance(value, bool) and value: |
Member
There was a problem hiding this comment.
Here value is True will also work
Member
Author
There was a problem hiding this comment.
Thanks. Did you know that you can already add suggestions on multiple lines?
https://github.blog/changelog/2020-02-26-multi-line-code-suggestions-beta/
Demo:
#8394 (comment)
Thanks to this, you can quickly edit files from Web UI.
Co-Authored-By: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
mik-laj
commented
Apr 19, 2020
mik-laj
commented
Apr 19, 2020
mik-laj
commented
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: https://issues.apache.org/jira/browse/AIRFLOW-2153
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.