Skip to content

[AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op #7685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 4 commits into from
Mar 12, 2020
Merged

[AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op #7685

potiuk merged 4 commits into from
Mar 12, 2020

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Mar 10, 2020 •
edited
Loading

It is possible to assign a task to the dag using the bitshift operators, however it doesn't pick up default_args when done this way https://issues.apache.org/jira/browse/AIRFLOW-883:

dag = DAG('my_dag', default_args=default_args)
dummy = DummyOperator(task_id='dummy')

dag >> dummy

Issue link: AIRFLOW-7034

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from ashb and potiuk March 10, 2020 17:12
@boring-cyborg boring-cyborg bot added area:docs provider:google Google (including GCP) related issues labels Mar 10, 2020
@kaxil kaxil requested a review from Fokko March 11, 2020 01:27
zhongjiajie
zhongjiajie approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code look good to me, but have some minor suggest here

@eladkal
Copy link
Contributor

eladkal commented Mar 11, 2020

I think removing features like this one should be mentioned in UPDATING.md.
Users who uses this feature will need to adjust their DAGs according to the change when upgrading.

@zhongjiajie
Copy link
Member

zhongjiajie commented Mar 11, 2020

I think removing features like this one should be mentioned in UPDATING.md.
Users who uses this feature will need to adjust their DAGs according to the change when upgrading.

Make sence

@kaxil
Copy link
Member Author

kaxil commented Mar 11, 2020

I think removing features like this one should be mentioned in UPDATING.md.
Users who uses this feature will need to adjust their DAGs according to the change when upgrading.

Agree, fixed

@zhongjiajie
Copy link
Member

zhongjiajie commented Mar 11, 2020

FYI, CI failed without more detail, should restart it to retest

@potiuk
Copy link
Member

potiuk commented Mar 11, 2020

Restarted

@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #7685 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #7685     +/-   ##
========================================
- Coverage   86.99%   86.7%   -0.3%     
========================================
  Files         904     904             
  Lines       43728   43728             
========================================
- Hits        38043   37916    -127     
- Misses       5685    5812    +127
Impacted Files Coverage Δ
airflow/providers/google/cloud/operators/pubsub.py 90.69% <ø> (ø) ⬆️
airflow/providers/amazon/aws/hooks/s3.py 96.46% <100%> (+0.12%) ⬆️
airflow/models/baseoperator.py 96.04% <100%> (-0.48%) ⬇️
airflow/utils/dag_processing.py 88.33% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-45.08%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.69% <0%> (-25.26%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/utils/process_utils.py 73.25% <0%> (-12.8%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6af02f...a695f27. Read the comment docs.

@kaxil kaxil requested a review from feng-tao March 12, 2020 00:28
@potiuk potiuk merged commit 137896f into apache:master Mar 12, 2020
@kaxil kaxil deleted the remove-assign-dag-task branch March 12, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@houqp houqp houqp approved these changes

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@ashb ashb Awaiting requested review from ashb

@Fokko Fokko Awaiting requested review from Fokko

@feng-tao feng-tao Awaiting requested review from feng-tao

Assignees

No one assigned

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kaxil @eladkal @zhongjiajie @potiuk @codecov-io @houqp