[v3-3-test] Fix crash when tailing logs of a running task instance (#69503)#69521
Merged
jason810496 merged 1 commit intoJul 8, 2026
Merged
Conversation
1 task
Lee-W
approved these changes
Jul 7, 2026
fd8ec55 to
b166450
Compare
…pache#69503) FileTaskHandler._read() returns an itertools.islice stream when resuming a log read via metadata["log_pos"] (introduced in apache#63531), but _is_logs_stream_like() only recognized chain and generator objects, so the public read() wrapper raised TypeError: Invalid log stream type... Got islice instead whenever a client polled or tailed a running task's logs. (cherry picked from commit 87089a5) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
b166450 to
779112b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileTaskHandler._read() returns an itertools.islice stream when resuming a log read via metadata["log_pos"] (introduced in #63531), but _is_logs_stream_like() only recognized chain and generator objects, so the public read() wrapper raised
TypeError: Invalid log stream type... Got islice instead whenever a client polled or tailed a running task's logs.
(cherry picked from commit 87089a5)