Skip to content

Improve Playwright test patterns in connections e2e tests#66058

Merged
choo121600 merged 1 commit into
apache:mainfrom
haseebmalik18:improve-e2e-tests-with-playwright-best-practices
May 6, 2026
Merged

Improve Playwright test patterns in connections e2e tests#66058
choo121600 merged 1 commit into
apache:mainfrom
haseebmalik18:improve-e2e-tests-with-playwright-best-practices

Conversation

@haseebmalik18

Copy link
Copy Markdown
Contributor

Improve Playwright test patterns in connections e2e tests

  • Remove redundant waitForLoadState("domcontentloaded") in ConnectionsPage.ts.
  • Replace manual expect(url).toContain() with web-first toHaveURL() in connections.spec.ts for auto-retry support.

closes: #63088

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 28, 2026
@haseebmalik18 haseebmalik18 force-pushed the improve-e2e-tests-with-playwright-best-practices branch from 826d5ba to ec818f9 Compare April 28, 2026 22:31

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also take a look at the fixme items?

Comment thread airflow-core/src/airflow/ui/tests/e2e/specs/connections.spec.ts
@haseebmalik18 haseebmalik18 force-pushed the improve-e2e-tests-with-playwright-best-practices branch from dffab17 to df03048 Compare April 29, 2026 05:18
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts Outdated
@haseebmalik18 haseebmalik18 force-pushed the improve-e2e-tests-with-playwright-best-practices branch from 71261a5 to 93a3668 Compare May 4, 2026 17:59
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/ConnectionsPage.ts Outdated
@haseebmalik18 haseebmalik18 force-pushed the improve-e2e-tests-with-playwright-best-practices branch from 93a3668 to 08593d3 Compare May 6, 2026 02:03

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@choo121600 choo121600 merged commit 6812207 into apache:main May 6, 2026
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Improve Playwright test patterns in connections.spec.ts

2 participants