Skip to content

Improve Playwright test patterns in dag-grid-view.spec.ts #63411#63415

Merged
choo121600 merged 3 commits into
apache:mainfrom
haseebmalik18:fix/e2e-improve-dag-grid-view-tests
Mar 14, 2026
Merged

Improve Playwright test patterns in dag-grid-view.spec.ts #63411#63415
choo121600 merged 3 commits into
apache:mainfrom
haseebmalik18:fix/e2e-improve-dag-grid-view-tests

Conversation

@haseebmalik18

@haseebmalik18 haseebmalik18 commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Improve Playwright test patterns in dag-grid-view.spec.ts and GridPage.ts to align with Playwright best practices.

  • Replace page.evaluate() with toHaveCSS() web-first assertion
  • Replace CSS a[href*="/tasks/"] selector with [data-node-id] data attribute
  • Replace manual role selector with getByRole("tooltip")
  • Replace imperative count checks with not.toHaveCount(0) web-first assertions
  • Move per-test setTimeout to describe-level

closes: #63411

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 12, 2026
choo121600
choo121600 reviewed Mar 12, 2026
View reviewed changes

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the CI is failing.
Could you take a look?

@potiuk potiuk marked this pull request as draft March 12, 2026 12:05
@potiuk

potiuk commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@haseebmalik18 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • ❌ Other failing CI checks: Failing: Additional PROD image tests / Chromium UI e2e tests with PROD image / Chromium UI e2e tests, Additional PROD image tests / Firefox UI e2e tests with PROD image / Firefox UI e2e tests, Additional PROD image tests / WebKit UI e2e tests with PROD image / WebKit UI e2e tests. Run prek run --from-ref main locally to reproduce. See static checks docs.

Note: Your branch is 6 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.

Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@haseebmalik18 haseebmalik18 force-pushed the fix/e2e-improve-dag-grid-view-tests branch from 6921ab4 to bbf6152 Compare March 12, 2026 19:15
@haseebmalik18 haseebmalik18 marked this pull request as ready for review March 13, 2026 01:19
choo121600
choo121600 reviewed Mar 13, 2026
View reviewed changes

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me :)
just one nit.

Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/GridPage.ts Outdated
@haseebmalik18 haseebmalik18 force-pushed the fix/e2e-improve-dag-grid-view-tests branch from e0b5d43 to a990abd Compare March 13, 2026 07:50
@haseebmalik18 haseebmalik18 force-pushed the fix/e2e-improve-dag-grid-view-tests branch from 524ce34 to edfca50 Compare March 13, 2026 14:17
@haseebmalik18

haseebmalik18 commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

@choo121600 made the changes

choo121600
choo121600 approved these changes Mar 14, 2026
View reviewed changes

@choo121600 choo121600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me thanks ;)

@choo121600 choo121600 merged commit 181b398 into apache:main Mar 14, 2026
80 checks passed
@gnosyslambda gnosyslambda mentioned this pull request Mar 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choo121600 choo121600 choo121600 approved these changes
@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner
@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner
@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner
@guan404ming guan404ming Awaiting requested review from guan404ming guan404ming is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2E: Improve Playwright test patterns in dag-grid-view.spec.ts

3 participants

@haseebmalik18 @potiuk @choo121600