Skip to content

[AIRFLOW-5379] Add Google Search Ads 360 operators #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mik-laj merged 4 commits into from
Oct 22, 2019
Merged

[AIRFLOW-5379] Add Google Search Ads 360 operators #6228

mik-laj merged 4 commits into from
Oct 22, 2019

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Oct 1, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #6228 into master will decrease coverage by 0.29%.
The diff coverage is 83.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6228     +/-   ##
=========================================
- Coverage   80.41%   80.11%   -0.3%     
=========================================
  Files         616      620      +4     
  Lines       35805    35940    +135     
=========================================
+ Hits        28791    28793      +2     
- Misses       7014     7147    +133
Impacted Files Coverage Δ
...keting_platform/example_dags/example_search_ads.py 0% <0%> (ø)
...ders/google/marketing_platform/hooks/search_ads.py 100% <100%> (ø)
...rs/google/marketing_platform/sensors/search_ads.py 100% <100%> (ø)
.../google/marketing_platform/operators/search_ads.py 93.42% <93.42%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4903c97...2a975f5. Read the comment docs.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 2, 2019
mik-laj
mik-laj reviewed Oct 2, 2019
View reviewed changes
mik-laj
mik-laj reviewed Oct 2, 2019
View reviewed changes
mik-laj
mik-laj reviewed Oct 2, 2019
View reviewed changes
@kaxil kaxil force-pushed the master branch 2 times, most recently from 558f9f1 to d719e1f Compare October 2, 2019 15:30
efolgar
efolgar suggested changes Oct 2, 2019
View reviewed changes
Copy link

@efolgar efolgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the hook, operators, and sensor for SA360.

@mik-laj
Copy link
Member

mik-laj commented Oct 3, 2019

@nuclearpinguin Can you add this operators to operators-and-hooks-ref.rst file?

@turbaszek turbaszek force-pushed the gcp-search-ads branch 2 times, most recently from de89444 to ea7a114 Compare October 3, 2019 13:08
@potiuk
Copy link
Member

potiuk commented Oct 11, 2019 •
edited
Loading

Approved but we need to move to the new providers/google packages.

@turbaszek turbaszek force-pushed the gcp-search-ads branch 2 times, most recently from 20f4e6f to c5f8403 Compare October 15, 2019 15:22
@turbaszek turbaszek force-pushed the gcp-search-ads branch 3 times, most recently from 4911b6c to 866e6ce Compare October 19, 2019 21:00
@mik-laj mik-laj merged commit 4e661f5 into apache:master Oct 22, 2019
@turbaszek turbaszek mentioned this pull request Oct 28, 2019
Closed
@KingsleyKelly KingsleyKelly mentioned this pull request Nov 4, 2019
Merged
@turbaszek turbaszek deleted the gcp-search-ads branch December 4, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mik-laj mik-laj mik-laj approved these changes

+1 more reviewer

@efolgar efolgar efolgar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@turbaszek @codecov-io @mik-laj @potiuk @efolgar