Skip to content

Return list of GCS URIs from SalesforceToGcsOperator#61659

Merged
shahar1 merged 2 commits into
apache:mainfrom
Prab-27:return-gcs-uri-list
May 5, 2026
Merged

Return list of GCS URIs from SalesforceToGcsOperator#61659
shahar1 merged 2 commits into
apache:mainfrom
Prab-27:return-gcs-uri-list

Conversation

@Prab-27

@Prab-27 Prab-27 commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Related : #11323

It returns str | list[str] in execute method from SalesforceToGcsOperator


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Feb 9, 2026
@Prab-27

Prab-27 commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

I need to run the system tests and unit tests .I’ll do all this once the connection is stable. It should work fine within 24 hours.

@Prab-27

Prab-27 commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

If I can’t run system tests, I’ll run unit tests instead, fix the issue, and ask someone to run the system tests.
(Please wait a couple of days while I fix the system tests.)

@Prab-27 Prab-27 marked this pull request as ready for review February 19, 2026 13:19
@Prab-27 Prab-27 requested a review from shahar1 as a code owner February 19, 2026 13:19
@Prab-27

Prab-27 commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@shahar1 it pass unit tests but system tests failed :

I tried in breeze container with pytest --system file but it will take some time - Related PR - here

I read this - here and tried to run it

I'm working on it and get back to you soon

@Prab-27 Prab-27 force-pushed the return-gcs-uri-list branch from c9dccd9 to 7f95234 Compare February 24, 2026 16:07

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I think that we should keep it simple in this case :)

@Prab-27 Prab-27 force-pushed the return-gcs-uri-list branch from 7f95234 to f1823d9 Compare March 9, 2026 08:44
@potiuk

potiuk commented Mar 12, 2026

Copy link
Copy Markdown
Member

@Prab-27 A few things need addressing before review — see our Pull Request quality criteria.

  • ⚠️ Unresolved review comments: This PR has 1 unresolved review thread from maintainers. Please review and resolve all inline review comments before requesting another review. You can resolve a conversation by clicking 'Resolve conversation' on each thread after addressing the feedback. See pull request guidelines.

Note: Your branch is 185 commits behind main. Please rebase and push again to get up-to-date CI results.

No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@yuseok89 yuseok89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prab-27
Are you still looking at this PR?
If so, I think we should first address the unresolved review comments, and then the next step will probably be system testing.
It’s been open for a while, so let me know if there’s anything you need help.

@Prab-27

Prab-27 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @yuseok89 !!
I was occupied and returned yesterday. I’m catching up on pending tasks and will address this shortly
If I couldn't resolve system tests I'll ping you
Apologize for the delay

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Prab-27 Prab-27 force-pushed the return-gcs-uri-list branch 2 times, most recently from b0dbf4f to 4bc6b26 Compare April 21, 2026 05:29
@potiuk potiuk marked this pull request as draft April 22, 2026 19:35
@potiuk

potiuk commented Apr 22, 2026

Copy link
Copy Markdown
Member

@Prab-27 This PR was triaged 41 days ago and has drifted — one maintainer thread is still unresolved. Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.

  • Unresolved review comments (1 thread from a maintainer): please walk through each unresolved review thread. Even if a suggestion looks incorrect or irrelevant — and some of them will be, especially any comments left by automated reviewers like GitHub Copilot — it is still the author's responsibility to respond: apply the fix, reply in-thread with a brief explanation of why the suggestion does not apply, or resolve the thread if the feedback is no longer relevant. Leaving threads unaddressed for weeks blocks the PR from moving forward.

See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk

potiuk commented Apr 22, 2026

Copy link
Copy Markdown
Member

Quick follow-up to the triage comment above — one clarification on the "Unresolved review comments" item:

Once you believe a thread has been addressed — whether by pushing a fix, or by replying in-thread with an explanation of why the suggestion doesn't apply — please mark the thread as resolved yourself by clicking the "Resolve conversation" button at the bottom of each thread. Reviewers don't auto-close their own threads, so an addressed-but-unresolved thread reads as "still waiting on the author" and keeps the PR from moving forward. The author doing the resolve-click is the expected convention on this project.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@Prab-27 Prab-27 force-pushed the return-gcs-uri-list branch from 4bc6b26 to 7dfb39d Compare May 3, 2026 18:49
@Prab-27 Prab-27 marked this pull request as ready for review May 3, 2026 18:56
@Prab-27

Prab-27 commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

@yuseok89 Would you please test these tests ?
I tried (from this) but couldn't do it !

@yuseok89

yuseok89 commented May 5, 2026

Copy link
Copy Markdown
Contributor

@shahar1 @Prab-27
I ran the tests for SalesforceToGcsOperator.

Test Screenshots

unwrap_single True

image

unwrap_single False

image

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! :)

@shahar1 shahar1 merged commit b3cbcb7 into apache:main May 5, 2026
144 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants