Skip to content

Providers: JDBC provider updated for conf import migration#60050

Closed
Aditi102005 wants to merge 6 commits into
apache:mainfrom
Aditi102005:fix-jdbc-provider-conf-import
Closed

Providers: JDBC provider updated for conf import migration#60050
Aditi102005 wants to merge 6 commits into
apache:mainfrom
Aditi102005:fix-jdbc-provider-conf-import

Conversation

@Aditi102005

@Aditi102005 Aditi102005 commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Updates the JDBC provider to stop importing conf from airflow.configuration
and instead use the shared compat SDK import:
from airflow.providers.common.compat.sdk import conf
This aligns the JDBC provider with the recommended approach for
Airflow 2.11+ and Airflow 3.x compatibility.
related #60000

@boring-cyborg

boring-cyborg Bot commented Jan 2, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Prab-27

Prab-27 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Thanks @Aditi102005 !!

The import statement airflow.configuration present in jdbc here and here

If possible we can update these statements

Comment thread providers/jdbc/pyproject.toml Outdated
@Aditi102005 Aditi102005 changed the title Providers: JDBC provider checked for conf import migration Providers: JDBC provider updated for conf import migration Jan 3, 2026
Comment thread providers/jdbc/pyproject.toml Outdated
@Prab-27

Prab-27 commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Static checks are failing !! Could you please fix them ?

@Aditi102005 Aditi102005 force-pushed the fix-jdbc-provider-conf-import branch from 2a67560 to 07ca8aa Compare January 4, 2026 19:33
Comment thread providers/jdbc/pyproject.toml Outdated
@potiuk

potiuk commented Jan 7, 2026

Copy link
Copy Markdown
Member

You have issues to fix - > both MyPy and regular static checks (which can be fixed with prek)

@Aditi102005

Copy link
Copy Markdown
Contributor Author

I’m working on Windows where some prek hooks (including mypy-providers and UI-related hooks) fail locally due to path/node limitations.
I’ve pushed a commit to trigger CI, which runs all MyPy and static checks on Linux.

@uranusjr

uranusjr commented Jan 8, 2026

Copy link
Copy Markdown
Member

Need to fix static checks. (You can also check locally with prek run -a ruff-format, this one should work on Windows.)

@sunank200

Copy link
Copy Markdown
Collaborator

@Aditi102005, this PR needs a fix for static checks.

@Srabasti

Copy link
Copy Markdown
Contributor

Hello @Aditi102005 -

The same static errors persist, unfortunately. It will be great to follow steps as per the documentation link mentioned below, to use WSL/Linux on your Windows machine, so no one has to suggest changes to you.
"prek" will fix the static errors for you by default, hence the time taken to merge your PR will be drastically reduced.

I was in same boat as you and after implementing as per steps in below link, have set up to be able run static checks from my end, before any PR commits. Please feel free to post any blockers in Slack channel #new-contributors, so the community can help out.

https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst

For the static error, if you observe closely, there is a line between the lines "requires-python = ">=3.10"" and "# The dependencies should be modified in place in the generated file." that got introduced as a typo when you were making changes, causing the static checks to fail. As mentioned above by everyone, using "prek" fixes any static checks automatically.

Good luck!

@eladkal

eladkal commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

@Aditi102005 PR should not change any files in airlfow-core nor task-sdk paths. Seems like a bad rebase?

@Aditi102005 Aditi102005 closed this Feb 3, 2026
@Aditi102005

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification.
The previous branch was not based on a clean upstream/main.
I’ve opened a new PR with only the JDBC provider changes on top of the latest upstream/main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants