Fix view for many DAG tags#55604
Merged
Merged
Conversation
Contributor
|
As we are close to a release we have locked all changes that modify translation keys. So as maintainers we need to consider if we change this last-minute and generate (more) translation gaps... Can you please add a "Before" / "After" Screenshot? This makes review easier. |
Member
|
I tried an experiment here - added my commit where I AI-generated all trasnslations following exisitng ones and maybe we can do it in the way that translators will just review and approve (or update) the translations for their language so that in the "freeze" period we can do a joined effort in a single PR. cc: @shahar1 -> WDYT ? |
36e7e06 to
82c553a
Compare
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…ts.json Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
…json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
…json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…json Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
e211986 to
f9085b7
Compare
Contributor
Author
|
Rebased! Thank you |
kaxil
pushed a commit
that referenced
this pull request
Oct 21, 2025
* fix view for many tags * fixup! fix view for many tags * Update airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ar/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/de/components.json Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/es/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/hi/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/it/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ko/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ar/components.json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/hu/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/components.json Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/tr/components.json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/tr/components.json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ca/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/he/components.json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/en/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/pl/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/pt/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/nl/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/fr/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * plurals & render fixes * fixup! plurals & render fixes * disable tooltip & enable modal, fix dutch translation * modal to popver, rmv subtitle, rmv tooltip comp * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> * Apply suggestion from @Lee-W Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> (cherry picked from commit 3b22cde)
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* fix view for many tags * fixup! fix view for many tags * Update airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ar/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/de/components.json Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/es/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/hi/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/it/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ko/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ar/components.json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/hu/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/components.json Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/tr/components.json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/tr/components.json Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/ca/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/he/components.json Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/en/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/pl/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/pt/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/nl/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * Update airflow-core/src/airflow/ui/public/i18n/locales/fr/components.json Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * plurals & render fixes * fixup! plurals & render fixes * disable tooltip & enable modal, fix dutch translation * modal to popver, rmv subtitle, rmv tooltip comp * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> * Apply suggestion from @Lee-W Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx * Update airflow-core/src/airflow/ui/src/components/LimitedItemsList.tsx --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add modal dialog to display all DAG tags when the tag list is truncated (more than 3 tags), allowing users to view and interact with all tags regardless of quantity.
Problem
The DAG tags display was limited to showing only the first 3 tags with a "+X more" tooltip that displayed additional tags in a cramped, non-interactive format. Users with DAGs containing many tags (20+ tags) had no way to properly view or click on the hidden tags
Solution
Added modal functionality to LimitedItemsList component
Testing
Tested with a DAG containing 25+ tags:
Related Issues
Fixes #55511