Skip to content

Drop support for Python 3.9#52072

Merged
eladkal merged 8 commits intoapache:mainfrom
eladkal:python39
Jun 27, 2025
Merged

Drop support for Python 3.9#52072
eladkal merged 8 commits intoapache:mainfrom
eladkal:python39

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Jun 23, 2025 •
edited
Loading

@potiuk
Copy link
Member

potiuk commented Jun 23, 2025

👀

@potiuk
Copy link
Member

potiuk commented Jun 23, 2025 

Prepare all required actions
Getting action download info
Download immutable action package 'actions/setup-python@v5'
  Version: 5.6.0
  Digest: sha[2](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:2)56:0b35a0c11c97499e4e05765890[3](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:3)6d450b9f5f9da74b7774225b3614b57324404
  Source commit SHA: a26af69be951a213d[4](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:4)95a4c3e4e4022e16d8706[5](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:5)
Run ./.github/actions/breeze
Run actions/setup-python@v5
  with:
    python-version: 3.9
    check-latest: false
    token: ***
    update-environment: true
    allow-prereleases: false
    freethreaded: false

3.9 is also hard-coded in a few github action workflows where it had to be added by hand (because you cannot run breeze before you install breeze to check which version of python is supported :D ) .

Classic chicken-egg

@eladkal eladkal force-pushed the python39 branch 3 times, most recently from f1a79b8 to f4590e6 Compare June 23, 2025 09:52
@eladkal eladkal force-pushed the python39 branch 4 times, most recently from 389da96 to 54587d1 Compare June 23, 2025 15:52
@gopidesupavan
Copy link
Member

gopidesupavan commented Jun 26, 2025 

Prepare all required actions
Getting action download info
Download immutable action package 'actions/setup-python@v5'
  Version: 5.6.0
  Digest: sha[2](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:2)56:0b35a0c11c97499e4e05765890[3](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:3)6d450b9f5f9da74b7774225b3614b57324404
  Source commit SHA: a26af69be951a213d[4](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:4)95a4c3e4e4022e16d8706[5](https://github.com/apache/airflow/actions/runs/15819890437/job/44586552024?pr=52072#step:5:5)
Run ./.github/actions/breeze
Run actions/setup-python@v5
  with:
    python-version: 3.9
    check-latest: false
    token: ***
    update-environment: true
    allow-prereleases: false
    freethreaded: false

3.9 is also hard-coded in a few github action workflows where it had to be added by hand (because you cannot run breeze before you install breeze to check which version of python is supported :D ) .

Classic chicken-egg

indeed :)

@potiuk
Copy link
Member

potiuk commented Jun 26, 2025 •
edited
Loading

ALMOST ... -> the (reverted) main issue AND one static check - sorting imports !!!

VERY, VERY CLOSE :)

amoghrajesh
amoghrajesh reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very close! I will take another look when CI is green!

@eladkal
Copy link
Contributor Author

eladkal commented Jun 27, 2025

Very very close! I will take another look when CI is green!

It's very hard to keep this PR green. For example the current failure is new, it started today and the fix applied in #52321 is insufficient for Python 3.10 because we need TypeAlias.

Kindly asking reviewers to review early so we can merge this fast.

gopidesupavan
gopidesupavan approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elad.

LGTM, mostly type changes ;)

@potiuk
Copy link
Member

potiuk commented Jun 27, 2025

Looks good (minus the current failures of course so indeed we should merge it quickly) - reviewed with git diff (higjhly recommended over GitHub UI) - helped to fix some reds and looked over it few times already.

There will be cherry-pick issues, but it's inevitable and we should just let peopel know to pay attention to the kinds of changes that they are expected to "revert" when cherry-picking.

amoghrajesh
amoghrajesh approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It mainly looks like type checking has had an impact, rest is pretty ok +1

@potiuk
Copy link
Member

potiuk commented Jun 27, 2025

👀 👀 .... and I might be able to complete 3.13 as a follow up....

@eladkal eladkal mentioned this pull request Jun 27, 2025
Merged
@potiuk
Copy link
Member

potiuk commented Jun 27, 2025

Wooohoooo !

@gopidesupavan
Copy link
Member

gopidesupavan commented Jun 27, 2025

Cool :)

@jscheffl
Copy link
Contributor

jscheffl commented Jun 27, 2025

Cool!

@bugraoz93
Copy link
Contributor

bugraoz93 commented Jun 27, 2025

Awesome!

@sjyangkevin sjyangkevin mentioned this pull request Jun 27, 2025
Merged
@jscheffl jscheffl mentioned this pull request Jun 27, 2025
Closed
@gopidesupavan gopidesupavan mentioned this pull request Jun 28, 2025
Merged
@potiuk potiuk mentioned this pull request Jun 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@kaxil kaxil kaxil approved these changes

@gopidesupavan gopidesupavan gopidesupavan approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@Fokko Fokko Awaiting requested review from Fokko Fokko is a code owner

@mik-laj mik-laj Awaiting requested review from mik-laj

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski is a code owner

@vincbeck vincbeck Awaiting requested review from vincbeck vincbeck is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@josh-fell josh-fell Awaiting requested review from josh-fell josh-fell is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@uranusjr uranusjr Awaiting requested review from uranusjr uranusjr is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:dev-tools area:helm-chart Airflow Helm Chart area:production-image Production image improvements and fixes area:providers provider:airbyte provider:alibaba provider:amazon AWS/Amazon - related issues provider:apache-beam provider:apache-cassandra provider:apache-drill provider:apache-druid provider:apache-flink provider:apache-hdfs provider:apache-hive provider:apache-iceberg provider:apache-impala provider:apache-kafka provider:apache-kylin provider:apache-livy upgrade to newer dependencies If set, upgrade to newer dependencies is forced

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eladkal @potiuk @jscheffl @gopidesupavan @bugraoz93 @kaxil @amoghrajesh