Skip to content

fix: Duplicate region in Snowflake URI no longer breaks OpenLineage#50831

Merged
mobuchowski merged 1 commit intoapache:mainfrom
kacpermuda:fix-ol-snowflake-uri
May 21, 2025
Merged

fix: Duplicate region in Snowflake URI no longer breaks OpenLineage#50831
mobuchowski merged 1 commit intoapache:mainfrom
kacpermuda:fix-ol-snowflake-uri

Conversation

@kacpermuda
Copy link
Collaborator

When debugging another issue, I came across some examples of Snowflake URI that will still execute the query, but break OpenLineage. Duplicated region in hostname seems to be ignored by Snowflake, but is causing OL to crash as we expect exactly 3 elements - locator, region, cloud.

This PR adjusts OL behaviour, so that it's consistent with Snowflake. This should only happen when user provides duplicate information in uri (f.e. region in account and also as separate argument). These are some examples of URIs that broke OL but still executed the query:

snowflake://user:pass@acc_locator.europe-west3.gcp/PUBLIC?account=acc_locator.europe-west3.gcp&region=europe-west3.gcp&database=TEST&warehouse=COMPUTE_WH&role=custom_role
snowflake://user:pass@acc_locator/PUBLIC?account=acc_locator.europe-west3.gcp&region=europe-west3.gcp&database=TEST&warehouse=COMPUTE_WH&role=custom_role
snowflake://user:pass@acc_locator/PUBLIC?account=acc_locator.europe-west3.gcp.europe-west3.gcp&region=europe-west3.gcp&database=TEST&warehouse=COMPUTE_WH&role=custom_role
snowflake://user:pass@europe-west3.gcp/PUBLIC?account=acc_locator.europe-west3.gcp&region=europe-west3.gcp&database=TEST&warehouse=COMPUTE_WH&role=custom_role
snowflake://user:pass@/PUBLIC?account=acc_locator.europe-west3.gcp&region=europe-west3.gcp&database=TEST&warehouse=COMPUTE_WH&role=custom_role

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants