Merged
Conversation
potiuk
approved these changes
Sep 5, 2024
Member
|
Thanks - yeah - this is common problem for Python 3.12. Possibly we should add some static check for that. |
Member
|
The problem is that I have not seen any ready-to-use ruff or other rule for that, only Python 3.12 will start to raise those exceptions: Not sure if we can automate it for Python 3.8 (and soon Python 3.9) automatically ? |
Member
|
I created an issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like #41658 introduced a typo in mock assertion code,
not_called()instead ofassert_not_called().This passed in Python 3.8-3.11, but Mock in 3.12 threw an error which killed 3.12 tests e.g. in #41555:
(I guess unittest.mock in 3.12 auto-detects when you intended to assert.)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.