Fix GCSSynchronizeBucketsOperator timeout error #37237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrao
reviewed
Feb 8, 2024
1e4d557 to
7f24237
Compare
Lee-W
approved these changes
Feb 15, 2024
a5f09e8 to
099937d
Compare
Update comment to be more clear
099937d to
8ee7ef1
Compare
potiuk
approved these changes
Feb 16, 2024
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #27488.
It solves the timeout error when trying to synchronize large files by using the
rewritefunction instead ofcopy.There was also previously a bug when synchronizing from a subdirectory where an empty subdirectory gets created which is solved by this PR.
For e.g synchronizing files in subdirectory
bigdata2from source bucket would unnecessarily create an emptybigdata2folder as seen in the image. This should not happen if I understand the docs correctly.The behaviour of GCSSynchronizeBucketsOperator otherwise remains the same.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.