Skip to content

Deprecate AutoMLTrainModelOperator for Vision and Video #36473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Jan 17, 2024
Merged

Deprecate AutoMLTrainModelOperator for Vision and Video #36473

potiuk merged 1 commit into from
Jan 17, 2024

Conversation

@VladaZakharova
Copy link
Contributor

@VladaZakharova VladaZakharova commented Dec 28, 2023

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@VladaZakharova VladaZakharova force-pushed the ml-vision-deprecate branch 4 times, most recently from 587ad6c to 53d13fb Compare January 9, 2024 07:53
@VladaZakharova VladaZakharova requested a review from Lee-W January 9, 2024 08:29
Lee-W
Lee-W approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick, but other parts looks good to me

@VladaZakharova
Copy link
Contributor Author

VladaZakharova commented Jan 16, 2024

Hi!
Can you please check this PR? :)
The service will be removed at the end of the month, so will be great to deprecate it at least :) Thank you!

Lee-W
Lee-W approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsed through it again. LGTM

@Lee-W
Copy link
Member

Lee-W commented Jan 16, 2024

If the text part is deprecated as well, should we added it to PR title?

@VladaZakharova
Copy link
Contributor Author

VladaZakharova commented Jan 16, 2024

If the text part is deprecated as well, should we added it to PR title?

Text was deprecated in another PR, long time ago :)

@Lee-W
Copy link
Member

Lee-W commented Jan 17, 2024

If the text part is deprecated as well, should we added it to PR title?

Text was deprecated in another PR, long time ago :)

Ah, yes, you're right. Missed the deleted docstring. Thanks for the prompt reply :)

@VladaZakharova
Copy link
Contributor Author

VladaZakharova commented Jan 17, 2024

@eladkal
Hi! Can you please check the PR? Thanks! :)

@potiuk potiuk merged commit 437d4e4 into apache:main Jan 17, 2024
@eladkal eladkal mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees

No one assigned

Labels

area:providers area:system-tests kind:documentation provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VladaZakharova @Lee-W @potiuk