Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Oct 13, 2023


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked only the big providers; most of the other providers have a single change (bump min version)

@josh-fell
Copy link
Contributor

Naïve question, but should we be bumping the minor version of the providers rather than the patch version based on the policy or is there some nuance to the version change?

... as of 2.3+ upgrade (November 2022) we only bump MINOR version of the provider when we increase minimum Airflow version.

Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked providers in which I made changes, in general seems fine.
Just one clarification might be required

@eladkal
Copy link
Contributor Author

eladkal commented Oct 13, 2023

Naïve question, but should we be bumping the minor version of the providers rather than the patch version based on the policy or is there some nuance to the version change?

yeah I set patch version by mistake I will fix it

@eladkal eladkal merged commit e9987d5 into apache:main Oct 13, 2023
@eladkal eladkal deleted the providers1 branch October 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants