Skip to content

Fix GCSToGoogleDriveOperator and gdrive system tests #34545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pankajastro merged 1 commit into from
Oct 12, 2023
Merged

Fix GCSToGoogleDriveOperator and gdrive system tests #34545

pankajastro merged 1 commit into from
Oct 12, 2023

Conversation

@moiseenkov
Copy link
Contributor

@moiseenkov moiseenkov commented Sep 22, 2023

Fix GCSToGoogleDriveOperator and gdrive system tests:

  • fixed race conditions in system tests when they run in parallel
  • added cleaning up to system tests, because files uploaded to gdrive remain there and it affects sensors regardless of what is going on in the current test run
  • changed the default value for the attribute GCSToGoogleDriveOperator.destination_folder_id for making it consistent with GoogleDriveHook.folder_id = "root". Previously the operator was passing the None value to the hook that expects only strings, which caused errors.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Sep 22, 2023
@moiseenkov moiseenkov force-pushed the system_tests/gdrive branch 2 times, most recently from b6b41dd to ac0fa8f Compare September 25, 2023 06:46
@moiseenkov moiseenkov force-pushed the system_tests/gdrive branch 3 times, most recently from 261058b to d79b99a Compare October 3, 2023 07:15
@moiseenkov
Copy link
Contributor Author

moiseenkov commented Oct 3, 2023

@eladkal , @kaxil , @Taragolis , hi,
can we merge this please?

eladkal
eladkal reviewed Oct 4, 2023
View reviewed changes
@moiseenkov moiseenkov requested a review from eladkal October 4, 2023 12:36
@moiseenkov moiseenkov force-pushed the system_tests/gdrive branch from d79b99a to 628b229 Compare October 5, 2023 14:19
pankajastro
pankajastro approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladaZakharova
Copy link
Contributor

VladaZakharova commented Oct 11, 2023

Hi @potiuk ! Could you please a look on the changes? Thank you :)

@pankajastro pankajastro merged commit 4dc2c40 into apache:main Oct 12, 2023
@eladkal eladkal mentioned this pull request Oct 13, 2023
Closed
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes

@Taragolis Taragolis Taragolis approved these changes

@pankajastro pankajastro pankajastro approved these changes

@eladkal eladkal Awaiting requested review from eladkal

Assignees

No one assigned

Labels

area:providers area:system-tests provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@moiseenkov @VladaZakharova @Taragolis @Lee-W @eladkal @pankajastro