Fix failing Celery Executor tests after config migration #32763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Celery Executor tests in Helm started to fail after the configuration migration has been merged (apache#32604). The PR did not have "full tests needed" label and it skipped K8S tests because there was no change related to kubernetes (but some fundamental changes in how configuration were retrieved caused the Celery Executor failed on missing default configuration value. The change adds ProvidersManager configuration initialization when executors are started in order to fix the problem temporarily, however there is an ongoing effort to optimise the path of retrieving provider configuration without having to initialize all provider's configuration and those lines will be removed when it happens.
Member
Author
|
Re-running with "full tests needed" this time. |
Member
Author
|
Yep. The fix seems to work. I will have another one improving it shortly, but woudl be great to merge that one to make main "green" again. |
eladkal
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Celery Executor tests in Helm started to fail after the configuration migration has been merged (#32604). The PR did not have "full tests needed" label and it skipped K8S tests because there was no change related to kubernetes (but some fundamental changes in how configuration were retrieved caused the Celery Executor failed on missing default configuration value.
The change adds ProvidersManager configuration initialization when executors are started in order to fix the problem temporarily, however there is an ongoing effort to optimise the path of retrieving provider configuration without having to initialize all provider's configuration and those lines will be removed when it happens.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.