Fix async KPO by waiting pod termination in execute_complete before cleanup#32467
Conversation
This reverts commit 8f5de83. Signed-off-by: Hussein Awala <hussein@awala.fr>
Signed-off-by: Hussein Awala <hussein@awala.fr>
|
@hussein-awala Was this introduced back? Or is this termination problem still happening in newest versions? |
The fix was released in cncf.kubernetes 7.3.0 (changelog), are you facing the same problem in a newer version? |
|
I meant the opposite. How do you feel, can this be reintroduced? Or was this solved in never version differently? |
|
In our case we didn't use |
closes: #32458
related: #31348
related: #31335
This PR reverts #31348 which doesn't handle the case where
do_xcom_pushis True, and move the waiting strategy toexecute_completein order to wait pod termination before calling the cleanup method.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.