Optimize deferrable mode execution in bigquery sensors #30946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cef412 to
54b6209
Compare
54b6209 to
68dcd4d
Compare
pankajastro
reviewed
Apr 29, 2023
| project_id=self.project_id, | ||
| poll_interval=self.poke_interval, | ||
| gcp_conn_id=self.gcp_conn_id, | ||
| hook_params={ |
Member
There was a problem hiding this comment.
I was looking at BigQueryTableExistenceTrigger and it has hook_params param but it does not use it so does it make sense to remove it from here wdyt?
potiuk
approved these changes
Apr 29, 2023
80 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deferrable mode , we should first check if the object being poked for is available or not in the execute method and only defer if that results in False. This way we don’t run an unnecessary deferral cycle if the condition is already true.
cc @dstandish
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.